Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Update CloudFormation template #6699

Merged
merged 6 commits into from Jun 27, 2023
Merged

Conversation

orouz
Copy link
Contributor

@orouz orouz commented Jun 26, 2023

What does this PR do?

Updates the cloudformation template to use a new one. see elastic/cloudbeat#1070

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@orouz orouz added enhancement New feature or request Team:Cloud Security Label for the Cloud Security team labels Jun 26, 2023
@orouz orouz requested a review from amirbenun June 26, 2023 15:02
@orouz orouz requested a review from a team as a code owner June 26, 2023 15:02
@elasticmachine
Copy link

elasticmachine commented Jun 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-27T09:06:21.315+0000

  • Duration: 13 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -68.333
Lines 100.0% (0/0) 💚 2.959
Conditionals 100.0% (0/0) 💚

Comment on lines 16 to 18
- description: Update CloudFormation template
type: enhancement
link: https://github.com/elastic/integrations/pull/6699
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using preview versions this section is not required anymore (we tend to add it for major changes).
So in that case you can remove it or leave it, your call.
However, in order to test it you should bump the preview version.

@orouz orouz requested a review from amirbenun June 27, 2023 06:58
@orouz orouz requested a review from orestisfl June 27, 2023 08:47
@orouz orouz merged commit 4dedcd4 into elastic:main Jun 27, 2023
4 checks passed
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview21 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview22 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview23 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview24 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview25 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview26 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview27 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants