Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elf.sections mapping to nested #6770

Merged
merged 2 commits into from Jul 1, 2023

Conversation

aleksmaus
Copy link
Member

What does this PR do?

Fixed the elf.sections mapping to make it nested.

Before this change:

    "elf": {
        "properties": {
            "creation_date": {
                "type": "date"
            },
            "header": {
                "properties": {
                    "entrypoint": {
                        "type": "long"
                    }
                }
            },
            "sections": {
                "properties": {
                    "chi2": {
                        "type": "long"
                    },
                    "entropy": {
                        "type": "long"
                    },
                    "physical_size": {
                        "type": "long"
                    },
                    "virtual_address": {
                        "type": "long"
                    },
                    "virtual_size": {
                        "type": "long"
                    }
                }
            }
        }
    }  

After the change (note the "type": "nested",:

{
    "elf": {
        "properties": {
            "creation_date": {
                "type": "date"
            },
            "header": {
                "properties": {
                    "entrypoint": {
                        "type": "long"
                    }
                }
            },
            "sections": {
                "type": "nested",
                "properties": {
                    "chi2": {
                        "type": "long"
                    },
                    "entropy": {
                        "type": "long"
                    },
                    "physical_size": {
                        "type": "long"
                    },
                    "virtual_address": {
                        "type": "long"
                    },
                    "virtual_size": {
                        "type": "long"
                    }
                }
            }
        }
    }
}

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@aleksmaus aleksmaus added the bug Something isn't working label Jun 30, 2023
@aleksmaus aleksmaus requested a review from kevinlog June 30, 2023 19:01
@aleksmaus aleksmaus requested a review from a team as a code owner June 30, 2023 19:01
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-30T19:01:20.595+0000

  • Duration: 14 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-30T19:02:20.619+0000

  • Duration: 13 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4) 👎 -65.476
Lines 100.0% (0/0) 💚 2.703
Conditionals 100.0% (0/0) 💚

1 similar comment
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4) 👎 -65.476
Lines 100.0% (0/0) 💚 2.703
Conditionals 100.0% (0/0) 💚

@patrykkopycinski patrykkopycinski merged commit 2149343 into elastic:main Jul 1, 2023
4 checks passed
@elasticmachine
Copy link

Package osquery_manager - 1.7.4 containing this change is available at https://epr.elastic.co/search?package=osquery_manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants