-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activemq package: revert back change to dynamic_dataset/namespace #6805
Merged
gsantoro
merged 2 commits into
elastic:main
from
gsantoro:feature/activemq_dynamic_dataset
Jul 6, 2023
Merged
Activemq package: revert back change to dynamic_dataset/namespace #6805
gsantoro
merged 2 commits into
elastic:main
from
gsantoro:feature/activemq_dynamic_dataset
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🌐 Coverage report
|
ruflin
approved these changes
Jul 4, 2023
Please change it to activemq? Also, please state why are we reverting this ? |
ishleenk17
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Package activemq - 0.13.0 containing this change is available at https://epr.elastic.co/search?package=activemq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Revert back changes from issue elastic/kibana#157897.
Removing the following configs from the activemq package manifest
We would like to revert these permissions in favour of creating a separate input package to reroute traffic from Activemq.
The idea is that we would like to have datastream-based integrations to monitor a specific application, while we should have input packages instead to reroute "mixed" traffic (from different sources) from that application.
The datastream
log
is actually looking at the activemq application logs, not at the traffic from activemq. This is why it doesn't make sense to allow rerouting for this package. Those logs should be in a fixed location (where they are right now).Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots