Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activemq package: revert back change to dynamic_dataset/namespace #6805

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

gsantoro
Copy link
Contributor

@gsantoro gsantoro commented Jul 4, 2023

What does this PR do?

Revert back changes from issue elastic/kibana#157897.

Removing the following configs from the activemq package manifest

elasticsearch.dynamic_dataset: true
elasticsearch.dynamic_namespace: true

We would like to revert these permissions in favour of creating a separate input package to reroute traffic from Activemq.

The idea is that we would like to have datastream-based integrations to monitor a specific application, while we should have input packages instead to reroute "mixed" traffic (from different sources) from that application.

The datastream log is actually looking at the activemq application logs, not at the traffic from activemq. This is why it doesn't make sense to allow rerouting for this package. Those logs should be in a fixed location (where they are right now).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gsantoro gsantoro added enhancement New feature or request v8.9.0 labels Jul 4, 2023
@gsantoro gsantoro requested a review from a team as a code owner July 4, 2023 10:24
@gsantoro gsantoro self-assigned this Jul 4, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-04T10:26:29.171+0000

  • Duration: 19 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 95.833% (23/24) 👍 10.119
Lines 85.321% (93/109) 👎 -8.451
Conditionals 100.0% (0/0) 💚

@ishleenk17
Copy link
Contributor

Removing the following configs from the system package manifest

Please change it to activemq?

Also, please state why are we reverting this ?

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gsantoro gsantoro merged commit 058b5e1 into elastic:main Jul 6, 2023
4 checks passed
@gsantoro gsantoro deleted the feature/activemq_dynamic_dataset branch July 6, 2023 10:02
@elasticmachine
Copy link

Package activemq - 0.13.0 containing this change is available at https://epr.elastic.co/search?package=activemq

gizas pushed a commit that referenced this pull request Sep 5, 2023
)

* Activemq package: revert back change to dynamic_dataset/namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants