Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1password: convert to lens #6819

Merged
merged 1 commit into from Jul 5, 2023
Merged

1password: convert to lens #6819

merged 1 commit into from Jul 5, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 5, 2023

What does this PR do?

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jul 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-05T08:41:55.553+0000

  • Duration: 14 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚 2.842
Classes 100.0% (3/3) 💚 2.842
Methods 90.909% (30/33) 👎 -1.239
Lines 87.888% (283/322) 👎 -3.926
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review July 5, 2023 09:28
@efd6 efd6 requested a review from a team as a code owner July 5, 2023 09:28
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 64f5a99 into elastic:main Jul 5, 2023
4 checks passed
@elasticmachine
Copy link

Package 1password - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=1password

gizas pushed a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants