Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka_log package: allow reroute to logs-*-* #6840

Merged
merged 2 commits into from Jul 7, 2023

Conversation

gsantoro
Copy link
Contributor

@gsantoro gsantoro commented Jul 6, 2023

What does this PR do?

Add permissions to write to logs--. Same changes as in this issue elastic/kibana#157897.

# Ensures agents have permissions to write data to `logs-*-*`
elasticsearch:
  dynamic_dataset: true
  dynamic_namespace: true

Similar change was applied to kafka package and then reverted at #6803. That was the wrong package to modify.

This package kafka_log is instead the right one, since it should reroute the traffic from Kafka

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@gsantoro gsantoro added enhancement New feature or request v8.9.0 labels Jul 6, 2023
@gsantoro gsantoro requested a review from a team as a code owner July 6, 2023 10:48
@gsantoro gsantoro self-assigned this Jul 6, 2023
@gsantoro gsantoro changed the title Kafka package: allow reroute to logs-*-* Kafka_log package: allow reroute to logs-*-* Jul 6, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-06T11:51:52.785+0000

  • Duration: 15 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 100.0% (3/3) 💚 4.167
Lines 100.0% (0/0) 💚 14.679
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gsantoro gsantoro merged commit 7ae0e82 into elastic:main Jul 7, 2023
4 checks passed
@gsantoro gsantoro deleted the feature/kafka_log_dynamic_dataset branch July 7, 2023 08:50
@elasticmachine
Copy link

Package kafka_log - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=kafka_log

gizas pushed a commit that referenced this pull request Sep 5, 2023
* dynamic_dataset/namespace for kafka_log integration

* fix the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants