network_traffic: fix mapping for tls.detailed.{client,server}_certificate_chain #6856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
reviewed
Jul 7, 2023
Comment on lines
164
to
165
| type: flattened | ||
| description: Chain of trust for the server certificate. |
There was a problem hiding this comment.
Suggested change
| type: flattened | |
| description: Chain of trust for the server certificate. | |
| type: group | |
| description: Chain of trust for the server certificate. | |
| fields: &certificate_object | |
| - name: alternative_names | |
| type: keyword | |
| description: Subject alternative names (SANs) in the certificate. | |
| - name: issuer | |
| type: group | |
| description: Issuer certificate metadata. | |
| fields: &x509_attributes | |
| - name: common_name | |
| type: keyword | |
| - name: country | |
| type: keyword | |
| - name: distinguished_name | |
| type: keyword | |
| - name: locality | |
| type: keyword | |
| - name: organization | |
| type: keyword | |
| - name: organizational_unit | |
| type: keyword | |
| - name: postal_code | |
| type: keyword | |
| - name: serial_number | |
| type: keyword | |
| - name: state_or_province | |
| type: keyword | |
| - name: street_address | |
| type: keyword | |
| - name: subject | |
| type: group | |
| description: Subject certificate metadata. | |
| fields: *x509_attributes | |
| - name: not_after | |
| type: date | |
| description: End of the validity period (inclusive). | |
| - name: not_before | |
| type: date | |
| description: Start of the validity period (inclusive). | |
| - name: public_key_algorithm | |
| type: keyword | |
| description: Public key algorithm (e.g. RSA, DSA, ECDSA, Ed25519). | |
| - name: public_key_size | |
| type: long | |
| description: Number of bits in the public key. | |
| - name: serial_number | |
| type: keyword | |
| description: Base 10 representation of the certificate serial number. | |
| - name: signature_algorithm | |
| type: keyword | |
| description: Signature algorithm (e.g. SHA256-RSA). | |
| - name: version_number | |
| type: keyword | |
| description: The x509 certificate version. Version 3 is the latest and most common. |
Comment on lines
167
to
221
| type: flattened | ||
| description: Chain of trust for the client certificate. |
There was a problem hiding this comment.
Suggested change
| type: flattened | |
| description: Chain of trust for the client certificate. | |
| type: group | |
| description: Chain of trust for the client certificate. | |
| fields: *certificate_object |
efd6
force-pushed
the
6842-network_traffic
branch
from
81e382d
to
f3e18ee
Compare
andrewkroh
approved these changes
Jul 10, 2023
|
Package network_traffic - 1.19.2 containing this change is available at https://epr.elastic.co/search?package=network_traffic |
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots