Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure] Ensure user_agent.original cannot be duplicated #6867

Merged
merged 2 commits into from Jul 10, 2023

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jul 7, 2023

What does this PR do?

This is the same fix as #5361 and #6866, but for the user_agent.original field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Run the following query in the dev tools:

POST _ingest/pipeline/logs-azure.signinlogs-1.5.26/_simulate
{
  "docs": [
    {
      "_source": {
        "message": {
          "properties": {
            "user_agent": "NCSA_Mosaic/2.0 (Windows 3.1)"
          }
        },
        "user_agent": {
          "original": "Stone Tablet (Paleolithic)"
        }
      }
    }
  ]
}

Related issues

Screenshots

@dmathieu dmathieu added the bugfix label Jul 7, 2023
@dmathieu dmathieu requested a review from a team as a code owner July 7, 2023 11:52
@dmathieu dmathieu changed the title ensure user_agent.original cannot be duplicated Ensure user_agent.original cannot be duplicated Jul 7, 2023
@andrewkroh andrewkroh changed the title Ensure user_agent.original cannot be duplicated [azure] Ensure user_agent.original cannot be duplicated Jul 7, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-10T08:06:19.144+0000

  • Duration: 13 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -15.297
Lines 85.003% (2817/3314) 👎 -8.25
Conditionals 100.0% (0/0) 💚

@dmathieu dmathieu merged commit 9dc8723 into main Jul 10, 2023
4 checks passed
@dmathieu dmathieu deleted the unique-user-agent branch July 10, 2023 08:19
@elasticmachine
Copy link

Package azure - 1.5.26 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants