Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Google Workspace] Convert visualisations to Lens #6914

Merged
merged 4 commits into from
Jul 13, 2023
Merged

[Google Workspace] Convert visualisations to Lens #6914

merged 4 commits into from
Jul 13, 2023

Conversation

chemamartinez
Copy link
Contributor

@chemamartinez chemamartinez commented Jul 11, 2023 •
edited
Loading

What does this PR do?

  • Updated the visualizations of Google Workspace dashboards to Lens
  • The screenshots were not updated since the integration already contains 7 screenshots and converted visualisations don't appear in them

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before
old-rules
Screenshot 2023-07-11 at 12 57 49

After
new-rules
Screenshot 2023-07-12 at 13 54 55

@chemamartinez chemamartinez self-assigned this Jul 11, 2023
@chemamartinez chemamartinez marked this pull request as ready for review July 11, 2023 11:08
@chemamartinez chemamartinez requested a review from a team as a code owner July 11, 2023 11:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@chemamartinez chemamartinez mentioned this pull request Jul 11, 2023
Closed
36 tasks
@elasticmachine
Copy link

elasticmachine commented Jul 11, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-12T11:54:33.768+0000

  • Duration: 27 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 112
Skipped 0
Total 112

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 11, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 100.0% (14/14) 💚
Classes 100.0% (14/14) 💚
Methods 100.0% (179/179) 💚 0.261
Lines 94.469% (4560/4827) 👎 -1.197
Conditionals 100.0% (0/0) 💚

kcreddy
kcreddy reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last visualisation (under Screenshots), the Y-Axis title Country Name doesn't seem to be accurate for what the metric is i.e., 0-1

@chemamartinez
Copy link
Contributor Author

In the last visualisation (under Screenshots), the Y-Axis title Country Name doesn't seem to be accurate for what the metric is i.e., 0-1

Sure thing, I've removed the Y-Axis title as it was before.

kcreddy
kcreddy approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemamartinez chemamartinez merged commit 43d3ba0 into elastic:main Jul 13, 2023
4 checks passed
@elasticmachine
Copy link

Package google_workspace - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=google_workspace

gizas pushed a commit that referenced this pull request Sep 5, 2023
@chemamartinez @gizas
[Google Workspace] Convert visualisations to Lens (#6914)
c94d035 
* Convert Google Workspace visualisations to Lens

* Bump integration version

* Update changelog

* Remove y-axis label in visualisation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@chemamartinez chemamartinez

Labels
enhancement New feature or request Integration:Google Workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chemamartinez @elasticmachine @kcreddy