Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CloudTrail standalone S3 option #6915

Merged
merged 5 commits into from Jul 19, 2023
Merged

Add CloudTrail standalone S3 option #6915

merged 5 commits into from Jul 19, 2023

Conversation

tdancheva
Copy link
Contributor

@tdancheva tdancheva commented Jul 11, 2023 •
edited

What does this PR do?

This PR adds an option to configure CloudTrail with a standalone S3 bucket option. The user has the option to choose between SQS and S3 with a toggle switch.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

cloudtrail-s3

@tdancheva tdancheva added the enhancement New feature or request label Jul 11, 2023
@tdancheva tdancheva marked this pull request as ready for review July 11, 2023 13:31
@tdancheva tdancheva requested a review from a team as a code owner July 11, 2023 13:31
@elasticmachine
Copy link

elasticmachine commented Jul 11, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-19T13:41:24.013+0000

  • Duration: 54 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 11, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.714% (240/280) 👍 60.714
Lines 85.925% (7387/8597) 👎 -14.075
Conditionals 100.0% (0/0) 💚

@tdancheva
Copy link
Contributor Author

/test

@tdancheva tdancheva mentioned this pull request Jul 12, 2023
Open
@tdancheva
Copy link
Contributor Author

/test

@kaiyan-sheng kaiyan-sheng mentioned this pull request Jul 17, 2023
Merged
4 tasks
@tdancheva tdancheva mentioned this pull request Jul 19, 2023
Merged
4 tasks
@tdancheva tdancheva merged commit 0890c70 into elastic:main Jul 19, 2023
4 checks passed
@tdancheva tdancheva deleted the cloudtrail-s3-option branch July 19, 2023 14:59
@elasticmachine
Copy link

Package aws - 1.48.0 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
@tdancheva @gizas
Add CloudTrail standalone S3 option (#6915)
51df39e 
* Add CloudTrail standalone S3 option

* Changelog and manifest

* Add S3 fields Cloudtrail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tdancheva @elasticmachine @kaiyan-sheng