Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cyberarkpas,darktrace,infoblox_bloxone_ddi,jamf_compliance_reporter,ti_abusech,ti_cybersixgill,zscaler_zpa: convert visualisations to len #6924

Merged
merged 4 commits into from Jul 12, 2023
Merged

cyberarkpas,darktrace,infoblox_bloxone_ddi,jamf_compliance_reporter,ti_abusech,ti_cybersixgill,zscaler_zpa: convert visualisations to len #6924

merged 4 commits into from Jul 12, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 12, 2023

What does this PR do?

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 12, 2023
@efd6 efd6 mentioned this pull request Jul 12, 2023
Closed
36 tasks
efd6 added 3 commits July 12, 2023 14:39
@efd6
cyberarkpas,darktrace,infoblox_bloxone_ddi,jamf_compliance_reporter,t…
493bdb5 
…i_abusech,ti_cybersixgill,zscaler_zpa: update dashboards to kibana.version 8.7.1
@efd6
cyberarkpas,darktrace,infoblox_bloxone_ddi,jamf_compliance_reporter,t…
77701aa 
…i_abusech,ti_cybersixgill,zscaler_zpa: convert visualisations to lens
@efd6
cyberarkpas,zscaler_zpa: clean up scars
8ec4cd4
@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-12T10:54:37.799+0000

  • Duration: 21 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 207
Skipped 0
Total 207

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (18/18) 💚
Files 100.0% (64/64) 💚
Classes 100.0% (64/64) 💚
Methods 99.739% (382/383) ❕
Lines 95.666% (11080/11582) ❕
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review July 12, 2023 05:32
@efd6 efd6 requested a review from a team as a code owner July 12, 2023 05:32
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to changelog description

packages/darktrace/changelog.yml Outdated
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.6.0"
changes:
- description: Convert vizualisation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Convert vizualisation.
- description: Convert vizualisations to lens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having a really hard time with spelling today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I see it too: "Oh no....." 😭

@efd6 efd6 force-pushed the 6787-solos branch 2 times, most recently from c8a8e15 to e512601 Compare July 12, 2023 10:49
@efd6 efd6 merged commit 0e61a67 into elastic:main Jul 12, 2023
4 checks passed
@elasticmachine
Copy link

Package cyberarkpas - 2.12.0 containing this change is available at https://epr.elastic.co/search?package=cyberarkpas

@elasticmachine
Copy link

Package darktrace - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=darktrace

@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

@elasticmachine
Copy link

Package jamf_compliance_reporter - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=jamf_compliance_reporter

@elasticmachine
Copy link

Package ti_abusech - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=ti_abusech

@elasticmachine
Copy link

Package ti_cybersixgill - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=ti_cybersixgill

@elasticmachine
Copy link

Package zscaler_zpa - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa

gizas pushed a commit that referenced this pull request Sep 5, 2023
@efd6 @gizas
cyberarkpas,darktrace,infoblox_bloxone_ddi,jamf_compliance_reporter,t…
1630325 
…i_abusech,ti_cybersixgill,zscaler_zpa: convert visualisations to len (#6924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:AbuseCH Integration:CyberArkPAS CyberArk Privileged Access Security Integration:Cybersixgill Integration:Darktrace Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI (DNS, DHCP, IP management) Integration:JAMF_Compliance_Reporter Integration:ZscalerZPA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efd6 @elasticmachine @kcreddy