Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for IBM MQ. #6928

Merged
merged 5 commits into from Jul 18, 2023
Merged

Update docs for IBM MQ. #6928

merged 5 commits into from Jul 18, 2023

Conversation

philippkahr
Copy link
Contributor

What does this PR do?

In the old metricbeat documentation we explicitly list that we only support containerized runtimes for the metricset collection and the reason. Metricbeat

I've updated the docs accordingly.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@philippkahr philippkahr added the enhancement New feature or request label Jul 12, 2023
@philippkahr philippkahr requested a review from a team as a code owner July 12, 2023 06:50
@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-17T13:30:18.772+0000

  • Duration: 18 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (20/20) 💚
Lines 98.904% (451/456)
Conditionals 100.0% (0/0) 💚

@lalit-satapathy
Copy link
Collaborator

@harnish-elastic, Please review the changes!

Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalit-satapathy
Copy link
Collaborator

@philippkahr, Please add a changelog and let's know once the CI is green. @harnish-elastic Please help as needed.

@harnish-elastic
Copy link
Contributor

@lalit-satapathy FYI, CI is green now.

Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippkahr philippkahr merged commit a4726ea into elastic:main Jul 18, 2023
4 checks passed
@philippkahr philippkahr deleted the ibmmq branch July 18, 2023 06:46
@elasticmachine
Copy link

Package ibmmq - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=ibmmq

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Migrate necessary info from metricbeat

* Suggestion to use data stream instead of metricset

* did run package check and copied Readme around

* Hope that's it

---------

Co-authored-by: harnish-elastic <118714680+harnish-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants