Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating rule names to match current #6942

Merged
merged 3 commits into from Jul 14, 2023
Merged

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Jul 12, 2023

What does this PR do?

This updates the filter for two lens visualizations on the dashboard to use the current rule names.

In 8.8 we deprecated the existing rules in favor of new, more specific names. This change was then backported to 8.5. So, this PR updates those names and sets the min version to 8.5

For more context, see https://elastic.slack.com/archives/C02TNUE3P6F/p1688126475454089

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@kgeller kgeller added the bugfix label Jul 12, 2023
@kgeller kgeller self-assigned this Jul 12, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-12T18:56:53.249+0000

  • Duration: 14 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kgeller kgeller marked this pull request as ready for review July 12, 2023 19:11
@kgeller kgeller requested a review from a team as a code owner July 12, 2023 19:11
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some screenshots to provide context for public users

packages/ti_util/manifest.yml Show resolved Hide resolved
@kgeller
Copy link
Contributor Author

kgeller commented Jul 14, 2023

@bhapas

Can we add some screenshots to provide context for public users

There already is one, and it doesn't change with this PR. It just gets fixed since the rule names have been updated

Screenshot 2023-07-14 at 9 06 02 AM

@kgeller kgeller requested a review from bhapas July 14, 2023 13:06
@kgeller kgeller merged commit 15d6a51 into elastic:main Jul 14, 2023
4 checks passed
@kgeller kgeller deleted the rules-updates branch July 14, 2023 13:11
@elasticmachine
Copy link

Package ti_util - 1.2.2 containing this change is available at https://epr.elastic.co/search?package=ti_util

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants