Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS][API Gateway] Set dimension fields #6950

Merged
merged 2 commits into from Jul 14, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Jul 13, 2023

What does this PR do?

Set the dimension fields for API Gateway data stream.

The dimension fields are:

  • ECS fields (decision for these fields is here):
    • agent.id
    • cloud.account.id
    • cloud.region
  • Other fields:
    • aws.dimensions.ApiId
    • aws.dimensions.ApiName
    • aws.dimensions.Method
    • aws.dimensions.Resource
    • aws.dimensions.Route
    • aws.dimensions.Stage

Passed the tests with 2 elastic agents running at the same time.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6293.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m self-assigned this Jul 13, 2023
@constanca-m constanca-m requested a review from a team as a code owner July 13, 2023 14:03
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Jul 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-13T14:05:12.851+0000

  • Duration: 56 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.476
Classes 93.75% (15/16) 👎 -3.476
Methods 85.714% (240/280) 👎 -6.443
Lines 85.925% (7387/8597) 👎 -5.199
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit a935388 into elastic:main Jul 14, 2023
4 checks passed
@constanca-m constanca-m deleted the aws-api-gateway branch July 14, 2023 07:13
gizas pushed a commit that referenced this pull request Sep 5, 2023
* Set dimension fields.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants