[AWS][API Gateway] Fix metric type #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
kaiyan-sheng
approved these changes
Jul 13, 2023
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
|
Package aws - 1.46.5 containing this change is available at https://epr.elastic.co/search?package=aws |
4 tasks
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Fix metric type. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update changelog. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Resolve conflicts. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> --------- Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All metric fields are calculated through an aggregation (
sumoravg). However, this is only for a given timestamp. On the next timestamp, new values will be used on the final aggregation and so on.Because of this, the value for some field,
4XXError.sumfor example, does not relate to the next4XXError.sumfield. The values are not cumulative over the different timestamps, and that is a requirement for acounterfield.All metric fields are gauge in this data stream.
Checklist
changelog.ymlfile.Related issues
Relates to #6293.