Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Firewall dashboards #6960

Merged
merged 2 commits into from Jul 17, 2023
Merged

Conversation

tdancheva
Copy link
Contributor

@tdancheva tdancheva commented Jul 14, 2023

What does this PR do?

This PR fixes a typo, replacing azure.account.id with cloud.account.id.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tdancheva tdancheva added the bug Something isn't working label Jul 14, 2023
@tdancheva tdancheva marked this pull request as ready for review July 14, 2023 08:41
@tdancheva tdancheva requested a review from a team as a code owner July 14, 2023 08:41
@elasticmachine
Copy link

elasticmachine commented Jul 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-14T08:40:25.665+0000

  • Duration: 15 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22)
Classes 86.364% (19/22)
Methods 83.333% (155/186)
Lines 85.003% (2817/3314)
Conditionals 100.0% (0/0) 💚

@tdancheva tdancheva merged commit 3c0feb7 into elastic:main Jul 17, 2023
4 checks passed
@tdancheva tdancheva deleted the fix-firewall-dashboards branch July 17, 2023 07:20
@elasticmachine
Copy link

Package azure - 1.5.27 containing this change is available at https://epr.elastic.co/search?package=azure

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Fix Firewall dashboards

* Changelog and manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants