Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MySQL] TSDB Enablement #6968

Merged
merged 5 commits into from Jul 24, 2023
Merged

[MySQL] TSDB Enablement #6968

merged 5 commits into from Jul 24, 2023

Conversation

agithomas
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR enables TSDB by default for the MySQL package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@agithomas agithomas mentioned this pull request Jul 17, 2023
Closed
19 tasks
@agithomas agithomas marked this pull request as ready for review July 17, 2023 09:17
@agithomas agithomas requested a review from a team as a code owner July 17, 2023 09:17
@agithomas
Copy link
Contributor Author

/test

@elasticmachine
Copy link

elasticmachine commented Jul 17, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-20T16:46:05.261+0000

  • Duration: 22 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@agithomas
Copy link
Contributor Author

/test

1 similar comment
@agithomas
Copy link
Contributor Author

/test

@elasticmachine
Copy link

elasticmachine commented Jul 18, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 5.882
Classes 100.0% (2/2) 💚 5.882
Methods 92.857% (26/28) 👍 6.995
Lines 94.34% (150/159) 👍 8.339
Conditionals 100.0% (0/0) 💚

@agithomas agithomas mentioned this pull request Jul 24, 2023
Closed
lalit-satapathy
lalit-satapathy approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the metric types(counter) as correct as per offline discussion with Agi.

@agithomas agithomas merged commit 6319410 into elastic:main Jul 24, 2023
4 checks passed
@elasticmachine
Copy link

Package mysql - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=mysql

gizas pushed a commit that referenced this pull request Sep 5, 2023
@agithomas @gizas
[MySQL] TSDB Enablement (#6968)
2c7395b 
* MySQL TSDB Enablement

* Updating minimum version as 8.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL TSDB Enablement
3 participants
@agithomas @elasticmachine @lalit-satapathy