Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f5_bigip: add support for log file input #6988

Merged
merged 2 commits into from
Jul 26, 2023
Merged

f5_bigip: add support for log file input #6988

merged 2 commits into from
Jul 26, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 17, 2023 •
edited
Loading

What does this PR do?

Add log file input to integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jul 17, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-26T13:00:04.583+0000

  • Duration: 16 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 17, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (6/6) 💚 5.263
Classes 100.0% (6/6) 💚 5.263
Methods 98.039% (50/51) 👍 0.991
Lines 95.786% (2682/2800) 👍 10.309
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review July 17, 2023 23:00
@efd6 efd6 requested a review from a team as a code owner July 17, 2023 23:00
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a thought, should we be using filestream input instead because its improved alternate to log input?

@efd6
Copy link
Contributor Author

efd6 commented Jul 26, 2023

Done. Thanks for the suggestion.

@efd6 efd6 force-pushed the 6269-f5_bigip branch 4 times, most recently from 36492de to 3e7edf3 Compare July 26, 2023 07:14
@kcreddy
Copy link
Contributor

kcreddy commented Jul 26, 2023

@efd6 I tried running tests on my end and when this line line_terminator: carriage_return_line_feed is removed from the log.yml.hbs file its working fine.

@efd6 efd6 merged commit 64aaf7c into elastic:main Jul 26, 2023
4 checks passed
@elasticmachine
Copy link

Package f5_bigip - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=f5_bigip

gizas pushed a commit that referenced this pull request Sep 5, 2023
@efd6 @gizas
f5_bigip: add support for filestream log input (#6988)
4d07837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:F5-BIGIP F5 BIG-IP integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[F5] BigIPAPM Add File input for Integration
3 participants
@efd6 @elasticmachine @kcreddy