Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][AWS] Migrate AWS Network Firewall input control to new control panel #6995

Merged
merged 2 commits into from Jul 19, 2023
Merged

[O11y][AWS] Migrate AWS Network Firewall input control to new control panel #6995

merged 2 commits into from Jul 19, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Jul 18, 2023 •
edited

Manually migrate AWS Network Firewall visualizations to the lens in the current Kibana version 8.8.1 itself.

Preparation of data for testing

  • Use sample_event.json / setup live instance using docker / mock data using a mock server to populate dashboards

Migration stats

AWS Network Firewall Dashboards Before Migration       After Migration      
  Control Panel Search Lens Visualization New Controls Search Lens Visualization
[Logs AWS] Firewall Alerts 1 1 14 0 1 1 14 0
[Logs AWS] Firewall Flows 1 1 14 0 1 1 14 0
[Logs AWS] Firewall Overview 1 1 9 0 1 1 9 0

Verification and Validation

  • Verification of functionality remains the same after migration in Kibana
  • Verification of data count of after-migrated visualization with before-migrated visualization in Kibana
  • Verification of Dashboards is not distorted in the supported Kibana version (TBD)

Related issues

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jul 18, 2023
Closed
5 tasks
@rajvi-patel-22 rajvi-patel-22 self-assigned this Jul 18, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 18, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T12:26:18.676+0000

  • Duration: 54 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.714% (240/280) 👍 19.048
Lines 85.925% (7387/8597) 👎 -14.075
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review July 18, 2023 13:12
@rajvi-patel-22 rajvi-patel-22 requested review from a team as code owners July 18, 2023 13:12
drewdaemon
drewdaemon approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kush-elastic kush-elastic self-requested a review July 19, 2023 05:47
kush-elastic
kush-elastic approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit ce55359 into elastic:main Jul 19, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 1.46.9 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
@rajvi-patel-22 @gizas
[O11y][AWS] Migrate AWS Network Firewall input control to new control…
1c82b16 
… panel (#6995)

* Migrate AWS Network Firewall dashboard input controls

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
Integration:AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][AWS] AWS Network Firewall Lens Migration
5 participants
@rajvi-patel-22 @elasticmachine @drewdaemon @kaiyan-sheng @kush-elastic