Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Set metric type #7033

Merged
merged 8 commits into from
Aug 2, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Jul 20, 2023

What does this PR do?

Set metric type for metric fields missing it.

For the filebeat_input data stream:

  • object type fields had to be converted for numeric field types. The reason for this is explained in this issue.
  • Can you please check:
    1. *.histogram.count is a gauge? My reasoning is that the next value can be less than the current value, so it keeps going up and down. Because of that it cannot be a counter.
    2. *.histogram.* is a gauge for the same reasoning?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6938.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m self-assigned this Jul 20, 2023
@constanca-m constanca-m requested a review from a team as a code owner July 20, 2023 11:45
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-01T06:51:10.668+0000

  • Duration: 14 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.828
Classes 100.0% (0/0) 💚 2.828
Methods 33.333% (25/75) 👎 -58.96
Lines 100.0% (0/0) 💚 9.02
Conditionals 100.0% (0/0) 💚

constanca-m and others added 2 commits July 31, 2023 08:07
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
constanca-m and others added 3 commits August 1, 2023 08:49
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m merged commit fd8fbd8 into elastic:main Aug 2, 2023
4 checks passed
@constanca-m constanca-m deleted the elastic-agent-metrics branch August 2, 2023 06:26
gizas pushed a commit that referenced this pull request Sep 5, 2023
* Set metric type.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants