Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dga] Ensure event.kind is correctly set for pipeline errors #7053

Merged
merged 4 commits into from Sep 11, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jul 20, 2023

What does this PR do?

Modify dga integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested review from a team as code owners July 20, 2023 16:25
@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-10T21:51:58.762+0000

  • Duration: 15 min 46 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Aug 10, 2023

/test

@botelastic
Copy link

botelastic bot commented Sep 9, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 9, 2023
@botelastic botelastic bot removed the Stalled label Sep 11, 2023
@MakoWish
Copy link
Contributor Author

FYI... As a contributor, I don't have permissions to merge.

@sodhikirti07
Copy link
Contributor

@elastic/ml-ui Can someone approve this PR before we merge the changes?

@peteharverson
Copy link
Contributor

@alvarezmelissa87 could you have a look at this one please.

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

@sodhikirti07 sodhikirti07 merged commit 1d7f1cf into elastic:main Sep 11, 2023
4 checks passed
@elasticmachine
Copy link

Package dga - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=dga

@MakoWish MakoWish deleted the 6582-dga branch September 11, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants