Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Add EMR logs dashboard #7075

Merged
merged 6 commits into from Jul 21, 2023
Merged

[AWS] Add EMR logs dashboard #7075

merged 6 commits into from Jul 21, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jul 20, 2023

What does this PR do?

Adds EMR logs dashboard. Also added data_stream.dataset filter.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

emr_logs

@gpop63 gpop63 self-assigned this Jul 20, 2023
nickofthyme
nickofthyme approved these changes Jul 20, 2023
View reviewed changes
Copy link

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON configuration LGTM 👍🏼

kaiyan-sheng
kaiyan-sheng approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the screenshot.

gpop63 and others added 2 commits July 21, 2023 00:32
@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-21T05:51:31.892+0000

  • Duration: 52 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 20, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -2.778
Classes 94.444% (17/18) 👎 -2.778
Methods 85.953% (257/299) 👎 -6.161
Lines 86.011% (7501/8721) 👎 -5.119
Conditionals 100.0% (0/0) 💚

@gpop63
Copy link
Contributor Author

gpop63 commented Jul 20, 2023

/test

@gpop63 gpop63 marked this pull request as ready for review July 20, 2023 22:14
@gpop63 gpop63 requested review from a team as code owners July 20, 2023 22:14
@gpop63
Copy link
Contributor Author

gpop63 commented Jul 20, 2023

/test

1 similar comment
@gpop63
Copy link
Contributor Author

gpop63 commented Jul 20, 2023

/test

@gpop63 gpop63 merged commit 70b8a84 into elastic:main Jul 21, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 1.50.3 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
@gpop63 @kaiyan-sheng @gizas
[AWS] Add EMR logs dashboard (#7075)
9a1d60f 
* add dashboard

* bump package version

* add dashboard img in manifest

* update the PR ID in changelog

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>

* fix dashboard migration versions for CI

---------

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees

@gpop63 gpop63

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gpop63 @elasticmachine @kaiyan-sheng @nickofthyme