Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Fix dashboards metric charts #7129

Merged
merged 8 commits into from Aug 10, 2023
Merged

[AWS] Fix dashboards metric charts #7129

merged 8 commits into from Aug 10, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jul 24, 2023 •
edited

What does this PR do?

Some dashboards were migrated to the newer metric chart type with color #FFF and they don't work well for the dark Kibana theme - they should use the default metric chart color.

  • Firewall metrics dashboard
  • NATGateway metrics dashboard
  • EC2 metrics dashboard
  • ELB metrics dashboard

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jul 24, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-10T12:42:49.835+0000

  • Duration: 55 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 24, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) ❕
Classes 94.444% (17/18) ❕
Methods 85.953% (257/299) ❕
Lines 86.011% (7501/8721) ❕
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review July 24, 2023 21:20
@gpop63 gpop63 requested review from a team as code owners July 24, 2023 21:20
@gpop63 gpop63 self-assigned this Jul 24, 2023
mbondyra
mbondyra approved these changes Jul 25, 2023
View reviewed changes
Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@drewdaemon
Copy link
Contributor

@elastic/obs-cloud-monitoring could we get a review here?

@gpop63 gpop63 requested a review from a team as a code owner August 10, 2023 12:42
@gpop63 gpop63 merged commit 1f96d4f into elastic:main Aug 10, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 1.52.1 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
@gpop63 @gizas
[AWS] Fix dashboards metric charts (#7129)
e9fd3a5 
* fix firewall_metrics dashboard metric charts color

* fix natgateway metrics dashboard metric charts color

* fix EC2 metrics dashboard metric charts color

* fix elb metrics dashboard metric charts color

* bump package version

* fix PR link in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@gpop63 gpop63

Labels
Integration:AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS] Fix dashboards metrics charts
6 participants
@gpop63 @elasticmachine @drewdaemon @mbondyra @kaiyan-sheng @andrewkroh