-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure] [Container-service] Add dimension and metric_type metadata to the container_service datastream #7139
[Azure] [Container-service] Add dimension and metric_type metadata to the container_service datastream #7139
Conversation
…stream Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
… using wildcard Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
🌐 Coverage report
|
packages/azure_metrics/data_stream/container_service/fields/package-fields.yml
Show resolved
Hide resolved
packages/azure_metrics/data_stream/container_service/fields/package-fields.yml
Outdated
Show resolved
Hide resolved
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@bturquet can you help us getting these reviewed? We have a long queue of Azure packages waiting on it. Merci |
type: keyword | ||
dimension: true | ||
description: Node name | ||
- name: status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is status
really required? Can a pod/container be in two different status in a given time series?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right, available values for this field are: True
(or true
) and False
(or false
). I will remove dimension from this
- name: condition | ||
type: keyword | ||
dimension: true | ||
description: The container name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the description. Does condition
and status
field. Both has same description. Is it correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What value goes under condition
to promote it as a dimension field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should |
@agithomas @zmoog could it be that this field was just copied from other datastreams, but it is not suppose to be here? regarding the |
This field mapping is included in all metrics data stream, including the Billing and Application Insights and Application State. I see the Application Insights' sample_event.json file has a There's a good chance |
…on: true for the azure.dimwnsions.status field; fix changelog merge conflict Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@agithomas I've added missing dimensions, can you please have another look on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Package azure_metrics - 1.0.19 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
… the container_service datastream (#7139) * Add dimension and metric_type metadata to the container_service data_stream Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * rename dimensions.* -> dimensions Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * add list of metrics to the azure.container_service object, instead of using wildcard Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * fix pr link and changelog Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * revert version Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * remove metrics.* fields; add agent.id as a dimension Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * push fields documentation changes Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
What does this PR do?
remove duplicated fields
instead of using wildcard in the field name - use predefined field names
- for azure.dimensions - dimension names are predefined - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerservice-managedclusters-metrics
- list of metrics - https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-containerservice-managedclusters-metrics
used fields for dimensions:
cloud.region
azure.resource.id
- this field includes azure.subscription_id, azure.resource.group, azure.resource.name, format:/subscriptions/{azure.subscription_id}/resourceGroups/{azure.resource.group}/providers/Microsoft.ContainerInstance/containerGroups/{azure.resource.name}
azure.dimensions.node
azure.dimensions.status
azure.dimensions.condition
azure.dimensions.pod
azure.timegrain
metrics - use predefined metrics - since in the configuration is defined list of metrics
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots