Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: harmonise powershell details regexp patterns #7192

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 31, 2023

What does this PR do?

The details regexp pattern for the powershell data stream was improved in #6154 to reduce backtracking costs that caused regexp costs to exceed the set runtime limits. The same pattern on other data streams was not updated. This change brings them up to date with the change.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jul 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-31T21:04:48.402+0000

  • Duration: 17 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 31, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 88.889% (8/9)
Classes 88.889% (8/9)
Methods 82.178% (83/101)
Lines 91.91% (5328/5797)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review July 31, 2023 03:47
@efd6 efd6 requested review from a team as code owners July 31, 2023 03:47
@efd6 efd6 requested review from ycombinator and faec July 31, 2023 03:47
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add similar pipeline tests here too?

The details regexp pattern for the powershell data stream was improved
to reduce backtracking costs that caused regexp costs to exceed the set
runtime limits. The same pattern on other data streams was not updated.
This change brings them up to date with the change.
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@efd6 efd6 requested a review from bhapas August 1, 2023 01:01
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit a7f586f into elastic:main Aug 1, 2023
4 checks passed
@elasticmachine
Copy link

Package windows - 1.28.1 containing this change is available at https://epr.elastic.co/search?package=windows

gizas pushed a commit that referenced this pull request Sep 5, 2023
The details regexp pattern for the powershell data stream was improved
to reduce backtracking costs that caused regexp costs to exceed the set
runtime limits. The same pattern on other data streams was not updated.
This change brings them up to date with the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants