[microsoft_dhcp] Add DHCP qresult descriptions #7207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
efd6
reviewed
Aug 1, 2023
packages/microsoft_dhcp/data_stream/log/elasticsearch/ingest_pipeline/dhcp.yml
Outdated
Show resolved
Hide resolved
|
/test |
🌐 Coverage report
|
…ipeline/dhcp.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
I didn't have any DHCPv6 logs indicating that this would align with them. |
|
/test |
|
Package microsoft_dhcp - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_dhcp |
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
Currently the QResult is stored in the event logs as a number which is usually 6 or 0 which will mean nothing to the end user if they don't understand the correlation. This change will add a new field called microsoft.dhcp.result_description to events based on that numerical value of the quarantine result. The event logs contain the mapping for this data and cannot be found in Microsoft's official documentation. This is from the DHCP event log when it gets created (Notice the QResult Line): ...snipped for brevity... 34 DNS update request failed.as the DNS update request queue limit exceeded. 35 DNS update request failed. 36 Packet dropped because the server is in failover standby role or the hash of the client ID does not match. 50+ Codes above 50 are used for Rogue Server Detection information. QResult: 0: NoQuarantine, 1:Quarantine, 2:Drop Packet, 3:Probation,6:No Quarantine Information ProbationTime:Year-Month-Day Hour:Minute:Second:MilliSecond. ID,Date,Time,Description,IP Address,Host Name,MAC Address,User Name, TransactionID, QResult,Probationtime, CorrelationID,Dhcid,VendorClass(Hex),VendorClass(ASCII),UserClass(Hex),UserClass(ASCII),RelayAgentInformation,DnsRegError. 24,07/28/23,00:00:52,Database Cleanup Begin,,,,,0,6,,,,,,,,,0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Today the QResult is stored in the event logs as a number which is usually 6 or 0 which will mean nothing to the end user if they don't understand the correlation.
This PR will add a new field called
microsoft.dhcp.result_descriptionto events based on that numerical value of the quarantine result. The event logs contain the mapping for this data and cannot be found in Microsoft's official documentation.This is from the DHCP event log when it gets created (Notice the QResult Line):
The mappings are as follows:
Checklist
changelog.ymlfile.