New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cisco ASA] Fix the handling of spaces in 113005 messages #7216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemamartinez
added
Team:Security-External Integrations
Integration:CiscoASA
Cisco ASA
bugfix
labels
Aug 2, 2023
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
ShourieG
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Package cisco_asa - 2.20.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa |
4 tasks
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
It fixes the parsing of 113005 Cisco ASA messages. The grok processor failed because of an unexpected space after `AAA user authentication Rejected`. This can potentially happen with every field so now the pattern expects that every value can be followed by spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the parsing of a 113005 Cisco ASA message as follows:
The
grok
processor failed because of an unexpected space afterAAA user authentication Rejected
. This can potentially happen with every field so now the pattern expects that every value can be followed by spaces.Checklist
changelog.yml
file.