Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Azure Billing] Migrate Azure Billing dashboard visualizations to lens #7219

Merged
merged 2 commits into from
Aug 16, 2023
Merged

[O11y][Azure Billing] Migrate Azure Billing dashboard visualizations to lens #7219

merged 2 commits into from
Aug 16, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Aug 2, 2023 •
edited by kush-elastic
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Azure Billing visualizations to the lens in the current Kibana version 8.3.0 itself.

  • Statistics for Azure Billing Lens migration:

Migration stats

  Before Migration After Migration
Dashboad Name Lens Visualization Lens Visualization
[Azure Billing] Billing overview 0 5 5 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 self-assigned this Aug 2, 2023
@rajvi-patel-22 rajvi-patel-22 added enhancement New feature or request Integration:Azure Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Aug 2, 2023
@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review August 2, 2023 10:52
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner August 2, 2023 10:52
@elasticmachine
Copy link

elasticmachine commented Aug 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-02T10:51:04.631+0000

  • Duration: 13 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (2/3) 👎 -20.195
Lines 100.0% (0/0) 💚 8.256
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic self-requested a review August 2, 2023 11:35
kush-elastic
kush-elastic approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Aug 2, 2023
Closed
5 tasks
gpop63
gpop63 approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@gpop63 gpop63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to add dataset filter for the whole dashboard here? Besides that, LGTM!

@rajvi-patel-22
Copy link
Contributor Author

Does it make sense to add dataset filter for the whole dashboard here? Besides that, LGTM!

I agree, the dashboard should have dataset filter to improve overall performance. I have created the issue: #7400

@rajvi-patel-22 rajvi-patel-22 merged commit 07761eb into elastic:main Aug 16, 2023
4 checks passed
@elasticmachine
Copy link

Package azure_billing - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=azure_billing

gizas pushed a commit that referenced this pull request Sep 5, 2023
@rajvi-patel-22 @gizas
[O11y][Azure Billing] Migrate Azure Billing dashboard visualizations …
b7fcbf9 
…to lens (#7219)

* Migrate Azure Billing dashboard visualizations to lens

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@gpop63 gpop63 gpop63 approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:Azure Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][Azure Billing] Lens Migration
5 participants
@rajvi-patel-22 @elasticmachine @zmoog @kush-elastic @gpop63