Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Add a CloudShell url param #7235

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

uri-weisman
Copy link
Contributor

What does this PR do?

  1. Make the project_id param optional as the user will not provide it in the CN deployment mode.
    Will be required by the UI component in the manual setup.
  2. Add a new input var for storing the Cloudshell URL that will be used to redirect the client.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@uri-weisman uri-weisman requested a review from a team as a code owner August 3, 2023 08:32
required: true
show_user: false
description: A URL to CloudShell for creating a new deployment
default: https://shell.cloud.google.com/cloudshell/?ephemeral=true&cloudshell_git_repo=https%3A%2F%2Fgithub.com%2Felastic%2Fcloudbeat&cloudshell_git_branch=8.10&cloudshell_workspace=deploy%2Fdeployment-manager&show=terminal
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon redirection the following will occur:

  1. Open the cloudshell session in ephemeral mode.
  2. Clone the Cloudbeat repo.
  3. git checkout to the 8.10 (will exist after the FF)
  4. cd to deploy/deployment-manager

@elasticmachine
Copy link

elasticmachine commented Aug 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-03T08:45:39.329+0000

  • Duration: 15 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@uri-weisman uri-weisman merged commit c19e6d9 into elastic:main Aug 3, 2023
4 checks passed
@uri-weisman uri-weisman deleted the update_gcp_integration branch August 3, 2023 09:08
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview29 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview30 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:cloud_security_posture Security Posture Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Add a CloudShell URL for the CIS GCP integration
4 participants