Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cisco FTD] Missing Geo Field Mappings #7267

Merged
merged 6 commits into from Aug 9, 2023
Merged

[Cisco FTD] Missing Geo Field Mappings #7267

merged 6 commits into from Aug 9, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Aug 4, 2023 •
edited

Type of change

  • Bug

What does this PR do?

This PR adds missing mappings for the fields destination.geo.postal_code and source.geo.postal_code to prevent field mapping conflicts in the logs-* Data View.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

cisco_ftd_conflict

@elasticmachine
Copy link

elasticmachine commented Aug 4, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-08T09:24:32.756+0000

  • Duration: 18 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 22
Skipped 0
Total 22

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@MakoWish MakoWish marked this pull request as ready for review August 4, 2023 15:47
@MakoWish MakoWish requested a review from a team as a code owner August 4, 2023 15:47
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh andrewkroh added the Integration:CiscoFTD Cisco FTD Firepower Threat Defense label Aug 4, 2023
kcreddy
kcreddy approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍🏼

@kcreddy
Copy link
Contributor

kcreddy commented Aug 8, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.392
Classes 100.0% (1/1) 💚 3.392
Methods 100.0% (22/22) 💚 8.183
Lines 70.724% (1406/1988) 👎 -17.52
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy merged commit 2b74688 into elastic:main Aug 9, 2023
4 checks passed
@elasticmachine
Copy link

Package cisco_ftd - 2.14.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

gizas pushed a commit that referenced this pull request Sep 5, 2023
@MakoWish @gizas
Add missing geo postal_code mappings (#7267)
4845968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees
No one assigned
Labels
Integration:CiscoFTD Cisco FTD Firepower Threat Defense
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cisco FTD] Missing Geo Field Mappings
4 participants
@MakoWish @elasticmachine @kcreddy @andrewkroh