[Juniper SRX] Fix grok patterns for system logs #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
chemamartinez
approved these changes
Aug 10, 2023
packages/juniper_srx/data_stream/log/elasticsearch/ingest_pipeline/system.yml
Outdated
Show resolved
Hide resolved
packages/juniper_srx/data_stream/log/elasticsearch/ingest_pipeline/system.yml
Outdated
Show resolved
Hide resolved
|
Thanks @chemamartinez! |
efd6
reviewed
Aug 10, 2023
packages/juniper_srx/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/juniper_srx/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/juniper_srx/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
efd6
approved these changes
Aug 14, 2023
P1llus
approved these changes
Aug 14, 2023
|
Package juniper_srx - 1.14.1 containing this change is available at https://epr.elastic.co/search?package=juniper_srx |
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Fix grok patterns for Juniper System logs * update pr num * update negotiation grok * Fix FW groks * Fix rtslib_dfwsm_get_async_cb * Add reth_scan * Non pid structured * Fix other patterns * Refactor * Add required fields * update readme * PR comments * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes existing grok patterns for system logs
Checklist
changelog.ymlfile.Author's Checklist
Waiting for the user who raised the request to get back on the issue comment. There are several instances where logs are not correctly formatted, or deviating from the standard.
Examples from
test-system.log:, Traffic-selector: FC Name:has no comma between fields, VR-ID: 5: Role: Initiatorhas:instead of,for field separator, VPN: IPSEC-NIKON-TUN1-PROD-VPN Gateway: IKE-NIKON-TUN1-GW,has,for field separator. Also present in multiple places.Confirmed by user that these can be ignored - [Juniper SRX] Issues with System message groks #6963 (comment)
How to test this PR locally
Related issues
Screenshots