New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Azure][compute_vm] Add dimensions, metric_type to the compute_vm datastream; remove dupl… #7293
[Azure][compute_vm] Add dimensions, metric_type to the compute_vm datastream; remove dupl… #7293
Conversation
…icated fields; extend azure.dimensions.* field with exact fields Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@@ -1,6 +1,7 @@ | |||
- name: azure.compute_vm.*.* | |||
type: object | |||
metric_type: gauge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: for float
it is not possible to use format:
- name: azure.compute_vm.*.*
type: float
metric_type: gauge
it causes this error:
Failed to parse mapping: No field type matched on [duck], possible values are [object, string, long, double, boolean, date, binary]
🌐 Coverage report
|
/test |
…tion] Reason: Mapping definition for [*] has unsupported parameters: [meta : {metric_type=gauge}] Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@@ -20,7 +20,7 @@ categories: | |||
- observability | |||
- azure | |||
conditions: | |||
kibana.version: "^8.3.0" | |||
kibana.version: "^8.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: It was intriduced due to this error:
[2023-08-17T08:30:18.282Z] Error: error running package asset tests: could not complete test run: can't install the package: can't install the package: could not install package; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"mapper_parsing_exception: [mapper_parsing_exception] Reason: Mapping definition for [*] has unsupported parameters: [meta : {metric_type=gauge}]"}
in CI was used stack version defined as a restriction: ../../build/elastic-package stack up -d -v --version 8.3.0
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Package azure_metrics - 1.0.28 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
…astream; remove dupl… (#7293) * add dimensions, metric_type to the compute_vm datastream; remove duplicated fields; extend azure.dimensions.* field with exact fields Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Update changelog.yml * set stack restriction to ^8.9.0 to fix CI error: mapper_parsing_exception] Reason: Mapping definition for [*] has unsupported parameters: [meta : {metric_type=gauge}] Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co> * Update manifest.yml --------- Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
…icated fields; extend azure.dimensions.* field with exact fields
What does this PR do?
agent.id
azure.dimensions.*
azure.namespace
- there might be multiple sources of metrics - for example for the same windows instance there can be availableMicrosoft.Compute/virtualMachines
andAzure.VM.Windows.GuestMetrics
metrics, both does not havedimensions
cloud.region
cloud.instance.id
- this is mainly added to follow the same rules as for aws/gcp,azure.resource.id
should be unique enoughazure.resource.id
azure.timegrain
agent.id
fieldmetric_type
to theazure.compute_vm.*.*
metricthere is planned a release with changes in spec, that fix the
elastic-package build
errorChecklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots