Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pulse_connect_secure] - update package-spec to 2.9.0 #7298

Merged
merged 2 commits into from Aug 9, 2023
Merged

[pulse_connect_secure] - update package-spec to 2.9.0 #7298

merged 2 commits into from Aug 9, 2023

Conversation

taylor-swanson
Copy link
Contributor

What does this PR do?

  • Update package-spec to 2.9.0
  • Ensure that observer.ip is an array
[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.9.0 -ecs-git-ref=v8.9.0 -format-version=2.9.0 packages/pulse_connect_secure

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Relates elastic/security-team#5870

@taylor-swanson
[pulse_connect_secure] - update package-spec to 2.9.0
5e7761f 
- Update package-spec to 2.9.0.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.9.0 -ecs-git-ref=v8.9.0 -format-version=2.9.0 -pr=1 packages/pulse_connect_secure
@taylor-swanson taylor-swanson self-assigned this Aug 7, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 7, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-07T18:54:07.050+0000

  • Duration: 18 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (13/13) 💚
Lines 91.27% (115/126) ❕
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review August 7, 2023 19:33
@taylor-swanson taylor-swanson requested a review from a team as a code owner August 7, 2023 19:33
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson taylor-swanson merged commit ea9d2c3 into elastic:main Aug 9, 2023
4 checks passed
@taylor-swanson taylor-swanson deleted the pkg-spec-pulse_connect_secure branch August 9, 2023 13:05
@elasticmachine
Copy link

Package pulse_connect_secure - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=pulse_connect_secure

gizas pushed a commit that referenced this pull request Sep 5, 2023
@taylor-swanson @gizas
[pulse_connect_secure] - update package-spec to 2.9.0 (#7298)
3123428 
- Update package-spec to 2.9.0.

[git-generate]
go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.9.0 -ecs-git-ref=v8.9.0 -format-version=2.9.0 packages/pulse_connect_secure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
enhancement New feature or request Integration:PulseConnectSecure Pulse Connect Secure integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taylor-swanson @elasticmachine @kgeller