New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Fix check on gcp.audit.authorization_info[].granted #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `gcp.audit.authorization_info[]` objects do not contain the `granted` attribute, the `if` statement fails. The updated `if` checks for null values and uses the `granted == true` syntax to avoid another error when there the `==` operator is not used: ``` Cannot invoke "Object.getClass()" because "value" is null ```
🌐 Coverage report
|
zmoog
changed the title
Fix check on gcp.audit.authorization_info[].granted
[GCP] Fix check on gcp.audit.authorization_info[].granted
Aug 8, 2023
zmoog
force-pushed
the
zmoog/gcp-audit-logs
branch
from
August 8, 2023 15:22
6b11263
to
ed458c3
Compare
kcreddy
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package gcp - 2.25.1 containing this change is available at https://epr.elastic.co/search?package=gcp |
4 tasks
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Fix check on gcp.audit.authorization_info[].granted When `gcp.audit.authorization_info[]` objects do not contain the `granted` attribute, the `if` statement fails. The updated `if` checks for null values and uses the `granted == true` syntax to avoid another error when there the `==` operator is not used: ``` Cannot invoke "Object.getClass()" because "value" is null ``` * Use `override` to avoid using a script expression * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
gcp.audit.authorization_info[]
objects do not contain thegranted
attribute, theif
statement fails.This PR updates the expression in the
if
to check for null values and uses thegranted == true
syntax to avoid another error when there the
==
operator is not used.The following error occurs with
... ctx?.gcp?.audit?.authorization_info[0]?.granted
andgranted
is null.Checklist
changelog.yml
file.How to test this PR locally
And then run the pipeline tests using the new
data_stream/audit/_dev/test/pipeline/test-sdh-3695.log
test case:Related issues