Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS][cloudwatch_metrics] Use object metric type for the cloudwatch metrics #7327

Conversation

tetianakravchenko
Copy link
Contributor

What does this PR do?

In this previous PR - was mentioned that the expected field definition is:

type: object
object_type: double
object_type_mapping_type: "*"

As was mentioned in this comment defining type: double is not equal to the above, due to some differences in the generated dynamic_template. So was decided to switch back to the previous format

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner August 9, 2023 12:50
@elasticmachine
Copy link

elasticmachine commented Aug 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-09T12:51:54.661+0000

  • Duration: 60 min 26 sec

Test stats 🧪

Test Results
Failed 0
Passed 206
Skipped 4
Total 210

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18)
Classes 94.444% (17/18)
Methods 85.953% (257/299)
Lines 86.011% (7501/8721)
Conditionals 100.0% (0/0) 💚

@tetianakravchenko tetianakravchenko merged commit 2236361 into elastic:main Aug 10, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 1.51.1 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
…etrics (#7327)

* Use object metric type for the cloudwatch metrics

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix changelog link

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants