Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista NG Firewall] Enhancement for Additional ECS Network Fields #7353

Merged
merged 2 commits into from Aug 10, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Aug 10, 2023

Type of change

  • Enhancement

What does this PR do?

This PR adds parsing of network.bytes and network.packets

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@MakoWish MakoWish marked this pull request as ready for review August 10, 2023 14:48
@MakoWish MakoWish requested a review from a team as a code owner August 10, 2023 14:48
@elasticmachine
Copy link

elasticmachine commented Aug 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-10T22:15:59.168+0000

  • Duration: 16 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Aug 10, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 97.436% (38/39)
Lines 93.945% (962/1024)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit c6f804e into elastic:main Aug 10, 2023
4 checks passed
@elasticmachine
Copy link

Package arista_ngfw - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=arista_ngfw

gizas pushed a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Arista NG Firewall] Enhancement for Additional ECS Network Fields
3 participants