Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Add Windows AppLocker Data Stream (Packaged app-Deployment) #7393

Merged
merged 16 commits into from
Aug 17, 2023
Merged

[windows] Add Windows AppLocker Data Stream (Packaged app-Deployment) #7393

merged 16 commits into from
Aug 17, 2023

Conversation

nicpenning
Copy link
Contributor

  • Enhancement

What does this PR do?

Adding the Microsoft Windows AppLocker Packaged app-Deployment channel to the Windows Integration

Resolves Part of - #6979

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@nicpenning nicpenning requested review from a team as code owners August 15, 2023 23:22
@elasticmachine
Copy link

elasticmachine commented Aug 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T10:48:32.200+0000

  • Duration: 18 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@nicpenning
Copy link
Contributor Author

This should be ready for testing. Please advise!

@nicpenning nicpenning mentioned this pull request Aug 15, 2023
Closed
4 tasks
efd6
efd6 reviewed Aug 16, 2023
View reviewed changes
...ment/_dev/test/pipeline/test-events-microsoft-windows-applocker-packaged-app-deployment.json Outdated Show resolved Hide resolved
packages/windows/data_stream/applocker_packaged_app_deployment/agent/stream/httpjson.yml.hbs Show resolved Hide resolved
...dows/data_stream/applocker_packaged_app_deployment/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
...dows/data_stream/applocker_packaged_app_deployment/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
...dows/data_stream/applocker_packaged_app_deployment/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
...dows/data_stream/applocker_packaged_app_deployment/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/windows/data_stream/applocker_packaged_app_deployment/manifest.yml Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented Aug 16, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Aug 16, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 90.909% (10/11) 👎 -9.091
Classes 90.909% (10/11) 👎 -9.091
Methods 84.874% (101/119) 👍 11.541
Lines 92.553% (5593/6043) 👎 -7.447
Conditionals 100.0% (0/0) 💚

nicpenning and others added 5 commits August 15, 2023 20:44
@nicpenning @efd6
Update packages/windows/data_stream/applocker_packaged_app_deployment…
bd3dc0d 
…/elasticsearch/ingest_pipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@nicpenning @efd6
Update packages/windows/data_stream/applocker_packaged_app_deployment…
eb3293b 
…/elasticsearch/ingest_pipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@nicpenning @efd6
Update packages/windows/data_stream/applocker_packaged_app_deployment…
86738f4 
…/elasticsearch/ingest_pipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@nicpenning @efd6
Update packages/windows/data_stream/applocker_packaged_app_deployment…
486bb6d 
…/elasticsearch/ingest_pipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@nicpenning @efd6
Update packages/windows/data_stream/applocker_packaged_app_deployment…
679a58e 
…/manifest.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@efd6
Copy link
Contributor

efd6 commented Aug 16, 2023

/test

@nicpenning
Copy link
Contributor Author

Cleaned up null terminations, please test.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@nicpenning
Copy link
Contributor Author

All findings corrected. Please test!

@efd6
Copy link
Contributor

efd6 commented Aug 16, 2023

/test

efd6
efd6 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit a6bf281 into elastic:main Aug 17, 2023
4 checks passed
@elasticmachine
Copy link

Package windows - 1.31.0 containing this change is available at https://epr.elastic.co/search?package=windows

@nicpenning nicpenning deleted the windows-applocker-packaged-app-deployment branch August 17, 2023 02:48
gizas pushed a commit that referenced this pull request Sep 5, 2023
@nicpenning @gizas
[windows] Add Windows AppLocker Data Stream (Packaged app-Deployment) (…
84db362 
…#7393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Integration:Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicpenning @elasticmachine @efd6 @jamiehynds