Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modsecurity: make pipeline selection more robust when nginx is configured with server_tokens off #7397

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 16, 2023

What does this PR do?

The transaction.response.headers.Server field may be absent when server_tokens is set to off, so also consider the transaction.producer.connector field when determining pipeline to run. Also protect dereferences.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Ideally we would have a test for the case that is raised in the issue. I have asked for one from the reporter.

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Aug 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-24T00:55:12.152+0000

  • Duration: 16 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.35
Classes 100.0% (3/3) 💚 3.35
Methods 100.0% (30/30) 💚 8.137
Lines 91.832% (371/404) 👍 3.513
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review August 16, 2023 04:20
@efd6 efd6 requested a review from a team as a code owner August 16, 2023 04:20
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But would be nice to add the specific test scenario from the issue mentioned

@efd6 efd6 requested a review from bhapas August 24, 2023 00:55
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 46bf1cb into elastic:main Aug 24, 2023
4 checks passed
@elasticmachine
Copy link

Package modsecurity - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=modsecurity

gizas pushed a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Modsecurity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[modsecurity] Pipeline error in case of nginx server_tokens off
3 participants