New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Add support for GCP org #7403
Conversation
- name: organization_id | ||
type: text | ||
title: Organization Id | ||
multi: false | ||
required: false | ||
show_user: true | ||
- name: project_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the UI should indicate we support project_id
or organization_id
, not both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project_id
might be needed as well to decide in which project the deployment should reside.
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orouz do we need to update the changelog and manifest version? this is for 8.11, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orouz do we need to update the changelog and manifest version? this is for 8.11, right?
packages/cloud_security_posture/data_stream/findings/agent/stream/gcp.yml.hbs
Outdated
Show resolved
Hide resolved
packages/cloud_security_posture/data_stream/findings/agent/stream/gcp.yml.hbs
Outdated
Show resolved
Hide resolved
{{#if gcp.project_id}} | ||
project_id: {{gcp.project_id}} | ||
{{/if}} | ||
{{#if gcp.organization_id}} | ||
organization_id: {{gcp.organization_id}} | ||
{{/if}} | ||
account_type: {{gcp.account_type}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project_id
and organization_id
depend on the value of account_type
, so they may be missing. account_type
is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@animehart we would need to have a migration here on fleet to add account_type
when missing
Reference to fleet migrations that work on variable
https://github.com/elastic/kibana/tree/main/x-pack/plugins/fleet/server/saved_objects/migrations/security_solution
type: text | ||
title: Account Type | ||
multi: false | ||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought our custom ui required us to not use it but this isn't the case for this var.
packages/cloud_security_posture/data_stream/findings/manifest.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Uri Weisman <68195305+uri-weisman@users.noreply.github.com>
Package cloud_security_posture - 1.6.0-preview1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.6.0-preview11 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.6.0-preview12 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.6.0-preview13 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.6.0-preview14 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.6.0-preview15 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.6.0-preview16 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
Package cloud_security_posture - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture |
What does this PR do?
Adds 2 new input vars:
organization_id
andaccount_type
closes #7398
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues