Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[couchbase] Add dimension mapping to bucket datastream #7419

Merged
merged 3 commits into from Aug 22, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Aug 16, 2023

  • Enhancement

What does this PR do?

Add dimensions to bucket datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Build verification
    elastic-package build
    elastic-package stack up -v -d --services package-registry
  2. Document count verification after enablement
  3. Dashboard verification after enablement
  4. Index template verification
  5. Index mapping verification
  6. Index settings verification.

Related issues

Screenshots

image

@elasticmachine
Copy link

elasticmachine commented Aug 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-22T06:29:22.110+0000

  • Duration: 28 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@agithomas agithomas mentioned this pull request Aug 16, 2023
74 tasks
@agithomas
Copy link
Contributor Author

Disablement testing

{
  "acknowledged": true,
  "shards_acknowledged": true,
  "old_index": ".ds-metrics-couchbase.bucket-default-2023.08.16-000001",
  "new_index": ".ds-metrics-couchbase.bucket-default-2023.08.16-000002",
  "rolled_over": true,
  "dry_run": false,
  "conditions": {}
}

@elasticmachine
Copy link

elasticmachine commented Aug 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 100.0% (10/10) 💚 3.371
Classes 100.0% (10/10) 💚 3.371
Methods 100.0% (72/72) 💚 8.172
Lines 100.0% (1076/1076) 💚 11.661
Conditionals 100.0% (0/0) 💚

@agithomas agithomas changed the title Add dimension mapping to bucket datastream [couchbase] Add dimension mapping to bucket datastream Aug 22, 2023
@agithomas agithomas marked this pull request as ready for review August 22, 2023 06:05
@agithomas agithomas requested a review from a team as a code owner August 22, 2023 06:05
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor Author

/test

@agithomas agithomas merged commit 572122e into elastic:main Aug 22, 2023
4 checks passed
@elasticmachine
Copy link

Package couchbase - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=couchbase

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Add dimension mapping to bucket datastream

* Update PR link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants