Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CockroachDB] Revert metrics field definition to the format used befo… #7429

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Aug 17, 2023

  • Enhancement

What does this PR do?

Revert cockroachDB metrics field definition to the format used before introducing metric_type.
This is done because of this issue.
Although, CockroachDB remained unaffected by this issue. However, with the fix now accessible and the necessary changes present in the elastic-package, it's good to revert to the original format.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screenshot 2023-08-22 at 12 17 47 PM Screenshot 2023-08-21 at 2 44 39 PM Screenshot 2023-08-21 at 2 45 13 PM

@ritalwar ritalwar requested a review from a team as a code owner August 17, 2023 07:06
@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-17T07:07:46.902+0000

  • Duration: 15 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.401
Classes 100.0% (0/0) 💚 3.401
Methods 75.0% (3/4) 👎 -16.793
Lines 100.0% (0/0) 💚 11.666
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

Why the reverting is done? Can you link to the related issue?

@ritalwar
Copy link
Contributor Author

Why the reverting is done? Can you link to the related issue?

This is the issue.
CockroachDB remained unaffected by this issue. However, with the fix now accessible and the necessary changes present in the elastic-package, it's good to revert to the original format.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit dc645f2 into elastic:main Aug 22, 2023
4 checks passed
@elasticmachine
Copy link

Package cockroachdb - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=cockroachdb

gizas pushed a commit that referenced this pull request Sep 5, 2023
#7429)

* [CockroachDB] Revert metrics field definition to the format used before introducing metric_type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants