Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Couchbase] Add dimensions mapping to cache datastream #7430

Merged
merged 4 commits into from Aug 23, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Aug 17, 2023

  • Enhancement

What does this PR do?

Add dimensions to bucket datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Build verification
    elastic-package build
    elastic-package stack up -v -d --services package-registry
  2. Document count verification after enablement
  3. Dashboard verification after enablement
  4. Index template verification
  5. Index mapping verification
  6. Index settings verification.
  • Verified that there exists mapping time_series_dimensions mapping after tsdb enablement
  • Verified that there exists time_series settings after TSDB enablement.
  • Verified that the dashboards are not broken after the TSDB enablement.
  • Index rollover after TSDB disablement

Related issues

@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-22T10:34:42.117+0000

  • Duration: 27 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 100.0% (10/10) 💚
Classes 100.0% (10/10) 💚
Methods 100.0% (72/72) 💚 54.545
Lines 100.0% (1076/1076) 💚
Conditionals 100.0% (0/0) 💚

@agithomas agithomas mentioned this pull request Aug 16, 2023
74 tasks
@agithomas
Copy link
Contributor Author

Verification that the dashboard works ok

image

@agithomas
Copy link
Contributor Author

Sample of the prometheus metrics endpoint

sgw_cache_num_active_channels{database="beer-sample"} 0
sgw_cache_num_active_channels{database="travel-sample"} 0
# HELP sgw_cache_num_skipped_seqs num_skipped_seqs,
# TYPE sgw_cache_num_skipped_seqs counter
sgw_cache_num_skipped_seqs{database="beer-sample"} 30
sgw_cache_num_skipped_seqs{database="travel-sample"} 0
# HELP sgw_cache_pending_seq_len pending_seq_len,
# TYPE sgw_cache_pending_seq_len gauge
sgw_cache_pending_seq_len{database="beer-sample"} 0
sgw_cache_pending_seq_len{database="travel-sample"} 0
# HELP sgw_cache_rev_cache_bypass rev_cache_bypass,
# TYPE sgw_cache_rev_cache_bypass gauge
sgw_cache_rev_cache_bypass{database="beer-sample"} 0
sgw_cache_rev_cache_bypass{database="travel-sample"} 0
# HELP sgw_cache_rev_cache_hits rev_cache_hits,
# TYPE sgw_cache_rev_cache_hits counter
sgw_cache_rev_cache_hits{database="beer-sample"} 0
sgw_cache_rev_cache_hits{database="travel-sample"} 0
# HELP sgw_cache_rev_cache_misses rev_cache_misses,
# TYPE sgw_cache_rev_cache_misses counter
sgw_cache_rev_cache_misses{database="beer-sample"} 0
sgw_cache_rev_cache_misses{database="travel-sample"} 0

@agithomas agithomas marked this pull request as ready for review August 22, 2023 10:34
@agithomas agithomas requested a review from a team as a code owner August 22, 2023 10:34
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit e4388d0 into elastic:main Aug 23, 2023
4 checks passed
@elasticmachine
Copy link

Package couchbase - 1.2.1 containing this change is available at https://epr.elastic.co/search?package=couchbase

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Add dimensions mapping to cache datastream

* Updated PR link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants