Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O365] Fix API timestamp issue in CEL program #7432

Merged
merged 3 commits into from Aug 17, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Aug 17, 2023

What does this PR do?

Fixes the following issue:

  • Whenever an error (user configured, such as insufficient token permissions, setting initial_interval longer than 7 days which is unsupported by API) occurred inside the CEL program the timestamps are saved in its state. If the error is resolved after few days the CEL program tries to fetch the data starting from the saved timestamp which could now be more than 7 days ago. However, based on API spec, the startTime parameter shouldn't be more than 7 days old.
  • API reference
  • This PR fixes the issue by checking if the saved timestamp inside the state is more than 7 days ago. If so, it defaults to 7 days.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-17T10:33:20.125+0000

  • Duration: 15 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚 26.667
Lines 80.994% (733/905) 👎 -19.006
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review August 17, 2023 10:30
@kcreddy kcreddy requested a review from a team as a code owner August 17, 2023 10:30
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy merged commit df3598b into elastic:main Aug 17, 2023
4 checks passed
@elasticmachine
Copy link

Package o365 - 1.20.1 containing this change is available at https://epr.elastic.co/search?package=o365

gizas pushed a commit that referenced this pull request Sep 5, 2023
* update cel prog

* update CEL program

* Update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants