Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Disable TSDB on AWS Billing #7435

Merged
merged 2 commits into from Aug 17, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

Disables TSDB on AWS Billing.

The reason for this decision is explained in this issue.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m self-assigned this Aug 17, 2023
@constanca-m constanca-m requested review from a team as code owners August 17, 2023 10:13
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-17T10:14:23.682+0000

  • Duration: 53 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 208
Skipped 4
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -5.556
Classes 94.444% (17/18) 👎 -5.556
Methods 85.953% (257/299) 👍 12.62
Lines 86.024% (7509/8729) 👎 -13.976
Conditionals 100.0% (0/0) 💚

@@ -1,7 +1,5 @@
title: AWS Billing Metrics
type: metrics
elasticsearch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it actually cause a rollover of the index?
what will be the index_mode of a new index (after rollover)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the other PR, this disables TSDB on all AWS Billing versions, so there should never exist a TSDB index for this. But, if in case it is enabled and we rollover, I am not sure if it will do the update automatically or if it is like changing look_ahead and we have to do it manually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if in case it is enabled and we rollover, I am not sure if it will do the update automatically or if it is like changing look_ahead and we have to do it manually.

my question is mainly for the case when tsdb is already enabled and we are trying to upgrade the package version. I think we need to test this scenario to understand how it works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agree, it is harder to test without doing the manual rollover because of the 24h.

@constanca-m constanca-m merged commit 1e5775b into elastic:main Aug 17, 2023
4 checks passed
@constanca-m constanca-m deleted the disable-aws-billing-main branch August 17, 2023 15:37
@elasticmachine
Copy link

Package aws - 1.53.1 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Disable TSDB on AWS Billing.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants