Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][PHP-FPM] Resolve the conflict in host.ip field #7444

Merged
merged 4 commits into from Aug 29, 2023
Merged

[O11y][PHP-FPM] Resolve the conflict in host.ip field #7444

merged 4 commits into from Aug 29, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Bug

What does this PR do?

Added host.ip field in ecs.yml and added re-indexing steps to resolve conflicts for existing users.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@harnish-elastic harnish-elastic self-assigned this Aug 17, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review August 17, 2023 11:59
@harnish-elastic harnish-elastic requested a review from a team as a code owner August 17, 2023 11:59
@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-28T12:35:40.152+0000

  • Duration: 16 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 17, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 8.333
Classes 100.0% (2/2) 💚 8.333
Methods 100.0% (16/16) 💚 14.844
Lines 95.763% (226/236) 👍 3.303
Conditionals 100.0% (0/0) 💚

milan-elastic
milan-elastic approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

muthu-mps
muthu-mps approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aliabbas-elastic aliabbas-elastic mentioned this pull request Aug 29, 2023
Merged
3 tasks
@harnish-elastic harnish-elastic merged commit 38c21e3 into elastic:main Aug 29, 2023
4 checks passed
@elasticmachine
Copy link

Package php_fpm - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=php_fpm

gizas pushed a commit that referenced this pull request Sep 5, 2023
@harnish-elastic @gizas
[O11y][PHP-FPM] Resolve the conflict in host.ip field (#7444)
ce66e01 
* resolve the conflict in host.ip field

* update changelog.yml

* update re-indexing steps

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
bugfix Integration:php-fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][PHP-FPM] Conflicts in host.ip field
4 participants
@harnish-elastic @elasticmachine @muthu-mps @milan-elastic