Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][GCP] Migrate GCP Load Balancing HTTPS Overview dashboard to lens #7458

Merged
merged 3 commits into from Aug 31, 2023
Merged

[O11y][GCP] Migrate GCP Load Balancing HTTPS Overview dashboard to lens #7458

merged 3 commits into from Aug 31, 2023

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Aug 18, 2023 •
edited

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate GCP Load Balancing HTTPS visualizations to the lens in the current Kibana version 8.7.1 itself.

  • Statistics for GCP Load Balancing HTTPS Lens migration:

Migration stats

  Before Migration     After Migration    
  Lens Vizualization Old input controls Lens Vizualization New control panels
[Metrics GCP] Load Balancing HTTPS Overview 0 6 1 6 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

Screenshots

Before Migration

image

After migration

image

@kush-elastic kush-elastic self-assigned this Aug 18, 2023
@elasticmachine
Copy link

elasticmachine commented Aug 18, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-31T09:32:41.909+0000

  • Duration: 19 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 18, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 87.826% (101/115) 👍 54.493
Lines 96.0% (1464/1525) 👎 -4.0
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic mentioned this pull request Aug 18, 2023
Closed
7 tasks
@kush-elastic kush-elastic marked this pull request as ready for review August 18, 2023 12:15
@kush-elastic kush-elastic requested review from a team as code owners August 18, 2023 12:15
@kush-elastic kush-elastic requested a review from a team August 21, 2023 07:01
rajvi-patel-22
rajvi-patel-22 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit d78cdf2 into elastic:main Aug 31, 2023
4 checks passed
@elasticmachine
Copy link

Package gcp - 2.28.4 containing this change is available at https://epr.elastic.co/search?package=gcp

gizas pushed a commit that referenced this pull request Sep 5, 2023
@kush-elastic @gizas
[O11y][GCP] Migrate GCP Load Balancing HTTPS Overview dashboard to le…
11d13e9 
…ns (#7458)

* Migrate GCP Load Balancing HTTPS Overview dashboard to lens

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

Assignees

@kush-elastic kush-elastic

Labels
dashboard enhancement New feature or request Integration:GCP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kush-elastic @elasticmachine @zmoog @rajvi-patel-22