Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][GCP] Migrate GCP Load Balancing L3 Overview dashboard to lens #7461

Merged
merged 2 commits into from Aug 28, 2023
Merged

[O11y][GCP] Migrate GCP Load Balancing L3 Overview dashboard to lens #7461

merged 2 commits into from Aug 28, 2023

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Aug 18, 2023 •
edited

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate GCP Load Balancing L3 visualizations to the lens in the current Kibana version 8.7.1 itself.

  • Statistics for GCP Load Balancing TCP L3 Lens migration:

Migration stats

  Before Migration     After Migration    
  Lens Vizualization Old Control panels Lens Vizualization New Input controls
[Metrics GCP] Load Balancing L3 Overview 0 4 1 4 0 1

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

Screenshots

Before migration

image

After migration

image

@kush-elastic kush-elastic self-assigned this Aug 18, 2023
@kush-elastic kush-elastic mentioned this pull request Aug 18, 2023
Closed
7 tasks
@elasticmachine
Copy link

elasticmachine commented Aug 18, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-18T10:10:06.215+0000

  • Duration: 20 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚 3.371
Classes 100.0% (6/6) 💚 3.371
Methods 87.826% (101/115) 👎 -4.033
Lines 96.0% (1464/1525) 👍 7.67
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic marked this pull request as ready for review August 21, 2023 05:21
@kush-elastic kush-elastic requested review from a team as code owners August 21, 2023 05:21
rajvi-patel-22
rajvi-patel-22 reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add screenshot of dashboard in PR description?

@kush-elastic
Copy link
Collaborator Author

Can you please add screenshot of dashboard in PR description?

Hey @rajvi-elastic,
I have added Screenshots in the PR description, you can re-review this PR now.
Thanks

@kush-elastic kush-elastic requested review from rajvi-patel-22 and a team August 21, 2023 05:29
rajvi-patel-22
rajvi-patel-22 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

zmoog
zmoog approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kush-elastic kush-elastic merged commit dc37b8d into elastic:main Aug 28, 2023
4 checks passed
@elasticmachine
Copy link

Package gcp - 2.28.0 containing this change is available at https://epr.elastic.co/search?package=gcp

gizas pushed a commit that referenced this pull request Sep 5, 2023
@kush-elastic @gizas
[O11y][GCP] Migrate GCP Load Balancing L3 Overview dashboard to lens (#…
8a09a16 
…7461)

* Migrate GCP Load Balancing L3 Overview dashboard to lens

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@rajvi-patel-22 rajvi-patel-22 rajvi-patel-22 approved these changes

Assignees

@kush-elastic kush-elastic

Labels
dashboard enhancement New feature or request Integration:GCP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kush-elastic @elasticmachine @zmoog @rajvi-patel-22