Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_ios: support ingesting NTP log messages #7466

Merged
merged 1 commit into from Aug 21, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 21, 2023

What does this PR do?

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Aug 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-21T04:57:31.150+0000

  • Duration: 19 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.367
Classes 100.0% (1/1) 💚 3.367
Methods 100.0% (15/15) 💚 8.173
Lines 91.436% (331/362) 👍 3.106
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review August 21, 2023 05:32
@efd6 efd6 requested a review from a team as a code owner August 21, 2023 05:32
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit c93f5cb into elastic:main Aug 21, 2023
4 checks passed
@elasticmachine
Copy link

Package cisco_ios - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:CiscoIOS Cisco IOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline fails to dissect NTP messages
3 participants