[Elastic Agent] Fix agent dashboard links for non default spaces #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P1llus
added
Team:Security-External Integrations
Team:Elastic-Agent
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
AndersonQ
approved these changes
Aug 21, 2023
|
Package elastic_agent - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent |
This was referenced Aug 21, 2023
gizas
pushed a commit
that referenced
this pull request
Sep 5, 2023
* [Elastic Agent] Fix agent dashboard links for non default spaces * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Referencing dashboards with markdown needs to be space-aware. Currently it was using a hyperlink that would always choose the default space on many occasions, the PR simply changes the markdown links to the correct format.
Tested all the links on all the dashboards after the changes, and they are working fine.
Checklist
changelog.ymlfile.How to test this PR locally
Elastic Agent integration is installed by default, open up the Dashboards UI and click on the Agent Overview dashboard, then click on any of the links in the table of contents on the left, this should now work in any space for all the links.
Related issues