[Azure Storage Account] Add metric_type metadata to the storage_account datastream #7488
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
|
||
| - name: azure.storage_account | ||
| type: group | ||
| fields: |
There was a problem hiding this comment.
We are not including:
IndexCapacityfrom https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-classicstorage-storageaccounts-blobservices-metricsFileShareQuotafrom https://learn.microsoft.com/en-us/azure/azure-monitor/reference/supported-metrics/microsoft-classicstorage-storageaccounts-fileservices-metrics
Is this intentional?
There was a problem hiding this comment.
Oh, please forget the comment about IndexCapacity, I could not find it but it's there. My Bad.
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh, this is surprising: how can FileShareQuota field from the docs become file_share_capacity_quota field in ES?
There was a problem hiding this comment.
I think this is being taken from here or sdk.
There was a problem hiding this comment.
Got it, thanks.
I see we have two documents for Azure Files:
- Supported metrics for Microsoft.ClassicStorage/storageAccounts/fileServices (from the links in the PR description)
- Azure Files monitoring data reference
Since the first one mentions the "Microsoft.ClassicStorage/storageAccounts" namespace, this may mean this for the classic version of the Files service, the the second for the current / modern version.
Are we supporting metrics for the classic namespace?
We should also check if we need add some *IOPS* related field in the current namespace doc, like:
FileShareMaxUsedIOPSFileShareProvisionedIOPSFileShareMaxUsedBandwidthMiBps
WDYT?
There was a problem hiding this comment.
Oops, my mistake! I referred to the classicStorage link instead of the correct one, which should be Microsoft.Storage/storageAccounts as this is the namespace we are supporting. To address this, I will update the metric_type mapping using the object type instead of the group format like this
- name: azure.storage_account.*.*
type: object
object_type: float
metric_type: gauge
object_type_mapping_type: "*"
description: >
storage account
This will ensure that all the fields within this namespace are correctly accounted for.
I didn't use this format before due to some issues associated with it. However, it seems those issues have been resolved, as I tested it successfully.
There was a problem hiding this comment.
Got it! Thanks for the check!
I'm not an expert in TSDB, but this makes sense.
I updated the link in the PR description with the non-classic one; please take a look to double-check if it's the correct one.
packages/azure_metrics/data_stream/storage_account/fields/fields.yml
Outdated
Show resolved
Hide resolved
|
/test |
ritalwar
changed the title
|
Package azure_metrics - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=azure_metrics |
What does this PR do?
This PR use predefined metrics and adds metric_type metadata to the storage_account datastream for all of these services, descriptions are also taken from here:
StorageAccount
BlobServices
FileServices
QueueServices
TableServices
Checklist
changelog.ymlfile.Related issues
Screenshots