Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS][EC2] Add metric type to EC2 #7490

Merged
merged 2 commits into from Aug 22, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Aug 22, 2023

What does this PR do?

Add metric type to EC2.

All metrics are gauge since they are all computed as aggregations.

There are a few numeric fields (example instance.state.code) that I did not mark as a metric, since they seem to be all constant.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #6293.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m added Integration:AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 22, 2023
@constanca-m constanca-m self-assigned this Aug 22, 2023
@constanca-m constanca-m requested review from a team as code owners August 22, 2023 08:42
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Aug 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-22T08:42:24.564+0000

  • Duration: 54 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 208
Skipped 4
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍
Classes 94.444% (17/18) 👍
Methods 85.953% (257/299) 👍
Lines 86.024% (7509/8729) 👍
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m merged commit 2f25340 into elastic:main Aug 22, 2023
4 checks passed
@constanca-m constanca-m deleted the ec2-add-metric-type branch August 22, 2023 13:48
@elasticmachine
Copy link

Package aws - 1.53.5 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Add metric type

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

* Update changelog.yml

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>

---------

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants